Skip to content

Conversation

@valyntyler
Copy link
Contributor

@valyntyler valyntyler commented Nov 3, 2025

Closes #1211

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🚀 Live preview deployed from a87439e

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: emmet-ls

Reruns: 1572

@valyntyler valyntyler changed the base branch from main to v0.8 November 3, 2025 17:53
@valyntyler valyntyler mentioned this pull request Nov 3, 2025
1 task
@NotAShelf NotAShelf changed the title Emmet ls languages/html: add emmet LSP Nov 6, 2025
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if you could just add a changelog entry this'll be ready to merge :)

github-actions bot pushed a commit that referenced this pull request Nov 6, 2025
@valyntyler
Copy link
Contributor Author

Looks good, if you could just add a changelog entry this'll be ready to merge :)

Awesome! Done.

@simonlearnscoding
Copy link

Very excited for this one to get merged because I've dearly missed emmet-ls since moving from vanilla nvim to nvf

@NotAShelf
Copy link
Owner

I could swear that I enabled automerge for this...

@NotAShelf NotAShelf merged commit a87439e into NotAShelf:v0.8 Nov 16, 2025
6 checks passed
@github-actions
Copy link

✅ Preview has been deleted successfully!

github-actions bot pushed a commit that referenced this pull request Nov 16, 2025
@valyntyler valyntyler deleted the emmet-ls branch November 19, 2025 20:14
@simonlearnscoding
Copy link

hey @valyntyler thank you this works for html! might be a noob question sorry for that but how can I enable this for .tsx and .jsx files?

@valyntyler
Copy link
Contributor Author

valyntyler commented Nov 20, 2025

hey @valyntyler thank you this works for html! might be a noob question sorry for that but how can I enable this for .tsx and .jsx files?

With a PR. It's on the way. #1235

@simonlearnscoding
Copy link

awsome thanks for keeping me up to date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants