codewindow: allow opening on setup #1259
Conversation
Vagahbond
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
NotAShelf
left a comment
NotAShelf
left a comment
There was a problem hiding this comment.
I would rather if this plugin was converted to setupOpts.
|
Ill see what I can do with HR |
|
Should be trivial, barely a breaking change. If you don't do it now you are FIRED |
codewindow: allow opening on setup
Vagahbond
force-pushed
the
codewindow-open-by-default
branch
from
082e0cd to
232e4a0
Compare
|
Please don't fire me I'll make you coffee ☕ |
|
Ok you're not fired |
|
CI failure is unrelated |
Soliprem
left a comment
Soliprem
left a comment
There was a problem hiding this comment.
Missing the release notes entry (something along the lines of "moved codewindow to setupOpts" should be fine)
|
Will do after breakfast |
codewindow: allow opening on setup
| in { | ||
| options.vim.minimap.codewindow = { | ||
| enable = mkEnableOption "codewindow plugin for minimap view"; | ||
| openByDefault = mkEnableOption "codewindow plugin opening automatically"; |
There was a problem hiding this comment.
oopsie failed conflict resolution
| description = "Open automatically"; | ||
| type = bool; | ||
| default = true; | ||
| }; | ||
|
|
||
| exclude_filetypes = mkOption { | ||
| description = "Excluded files types"; | ||
| type = listOf str; | ||
| default = ["NvimTree" "orgagenda" "Alpha"]; | ||
| }; |
There was a problem hiding this comment.
You can leave the mkPluginSetupOption args empty:
mkPluginSetupOption "codewindow" {}
and since it's always freeform, you'll be able to pass any option that you want. See the setupOpts section in the manual. I think this PR would be better off only converting to setupOpts instead of introducing new options, which we're trying to move away from.
| codewindow.setup( | ||
| ${lib.nvim.lua.toLuaObject cfg.setupOpts} | ||
| ) |
There was a problem hiding this comment.
| codewindow.setup( | |
| ${lib.nvim.lua.toLuaObject cfg.setupOpts} | |
| ) | |
| codewindow.setup(${cfg.setupOpts}) |
No reason not to inline this. You can also move the lib.nvim.lua.toLuaObject part to an inherit at the top, but not a hard-requirement.
| [vagahbond](https://github.com/vagahbond): | ||
|
|
||
| - moved [codewindow](https://github.com/gorbit99/codewindow.nvim) to setupOpts |
There was a problem hiding this comment.
Please match rest of the documentation, and format the file with deno fmt.
|
Don't merge it's actually broken |
3 participants
Add an option to open codewindow on NVF launch
Pretty straightforward
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.