Per Language Indent Config

[mewoocat]

Sanity Checking

• I have updated the changelog as per my changes
• I have tested, and self-reviewed my code
• My changes fit guidelines found in hacking nvf
• Style and consistency
  • I ran Alejandra to format my code (nix fmt)
  • My code conforms to the editorconfig configuration of the project
  • My changes are consistent with the rest of the codebase
• If new changes are particularly complex:
  • My code includes comments in particularly complex areas
  • I have added a section in the manual
  • (For breaking changes) I have included a migration guide
• Package(s) built:
  • .#nix (default package)
  • .#maximal
  • .#docs-html (manual, must build)
  • .#docs-linkcheck (optional, please build if adding links)
• Tested on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin

---

Add a 👍 reaction to pull requests you find important.

[github-actions]

🚀 Live preview deployed from ef1f22e

View it here:

Debug Information

Triggered by: mewoocat

HEAD at: main

Reruns: 1749

[horriblename]

I don't think these kinds of options are needed, vim typically provides a good default for most filetypes so it feels weird providing the same default for most filetypes. If you feel like vim's default is not good, consider making a PR upstream.

If the goal is a more convenient per-filetype option API, there are better ways to do so, e.g. mimicking the vim.options API, but for each filetype.

[mewoocat]

@horriblename

I don't think these kinds of options are needed, vim typically provides a good default for most filetypes so it feels weird providing the same default for most filetypes. If you feel like vim's default is not good, consider making a PR upstream.

oh I wasn't aware vim had any per filetype defaults, I'm not really finding much info on this. I had always thought the tab configuration was static.

If the goal is a more convenient per-filetype option API, there are better ways to do so, e.g. mimicking the vim.options API, but for each filetype.

I'm not sure I follow. Are you suggesting something like vim.options.<filetype>.indentSize as opposed to what I have now vim.languages.<lang>.indentSize?

[horriblename]

I'm not sure I follow. Are you suggesting something like vim.options..indentSize as opposed to what I have now vim.languages..indentSize?

something like vim.perFileTypeOptions.<lang>.shiftwidth

though I'd ask for opinions from @NotAShelf and @Soliprem first