Fix double registration of default multitouch device#5
Merged
NullPointerDepressiveDisorder merged 2 commits intosentryfrom Dec 4, 2025
Merged
Fix double registration of default multitouch device#5NullPointerDepressiveDisorder merged 2 commits intosentryfrom
NullPointerDepressiveDisorder merged 2 commits intosentryfrom
Conversation
Merged
Co-authored-by: NullPointerDepressiveDisorder <96403086+NullPointerDepressiveDisorder@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Sentry implementation based on feedback from PR #4
Fix double registration of default multitouch device
Dec 4, 2025
Copilot started reviewing on behalf of
NullPointerDepressiveDisorder
December 4, 2025 04:07
View session
NullPointerDepressiveDisorder
approved these changes
Dec 4, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where MTDeviceCreateDefault() could return a device pointer already present in the list from MTDeviceCreateList(), causing duplicate callback registration and inflated device counts.
Key Changes:
- Introduced a
Set<UnsafeMutableRawPointer>to track registered device pointers during startup - Added duplicate detection before registering the default device
- Added debug logging when a duplicate is detected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MTDeviceCreateDefault()returns a device that may already exist in the list fromMTDeviceCreateList(), causing duplicate callback registration and inflated device counts.Changes
Set<UnsafeMutableRawPointer>during startup💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.