Update NDArray stubs: fixed method signatures, added missing methods,…#1
Open
omegaalfa wants to merge 1 commit intoNumPower:mainfrom
Open
Update NDArray stubs: fixed method signatures, added missing methods,…#1omegaalfa wants to merge 1 commit intoNumPower:mainfrom
omegaalfa wants to merge 1 commit intoNumPower:mainfrom
Conversation
… and improved PHPDoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Description
This PR improves the stubs for the NDArray class in the NumPower extension to ensure greater consistency and alignment with the actual extension API:
✅ Fixed method signatures: Added missing parameters (e.g., axis, keepdims, etc.) in methods like max(), min(), and others, matching the official extension specification.
➕ Added missing methods: Implemented stubs for methods that were absent, based on the official documentation and C implementation review.
🔄 Updated composer.json: Minor adjustment (if applicable) to keep everything in sync.
💡 Motivation:
While integrating NumPower into PHP projects, I noticed some missing or inconsistent NDArray method signatures, which can affect IDE autocompletion and static analysis tools (e.g., PhpStorm, Psalm). This PR aims to enhance the developer experience and accuracy of the stubs.