Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updated so that when a preview team is removed from a bundle, dataset information is removed from the condition on the permissions policy
Jira - https://officefornationalstatistics.atlassian.net/browse/DIS-4533
How to review
To test locally, run the local stack and for acceptance criteria 1 and 2 -
Create a bundle with a preview team
Add a content item (dataset/edition) to the bundle
Confirm that the policy has the correct values ["dataset-id", "dataset-id/edition-id"]
Remove the preview team from the bundle
Confirm that the policy values field is now null
For acceptance criteria 3 -
Create two bundles both with the same preview team
Add different editions of the same dataset to each bundle (for example dataset-id/edition-1 in bundle 1, dataset-id/edition-2 in bundle 2)
Confirm that policy has ["dataset-id", "dataset-id/edition-1", "dataset-id/edition-2"]
Remove the team from bundle 1
Confirm that policy now has ["dataset-id", "dataset-id/edition-2"] (edition-1 removed, dataset-id is still there)
Changes make sense, tests pass
Who can review
Anyone