feat(frontend): Refine Gap Analysis link strength categorization (Weak threshold 20 -> 7)#717
Merged
northdpole merged 4 commits intoOWASP:mainfrom Feb 14, 2026
Conversation
Contributor
Author
|
Hi @northdpole Verification Report
Always open to iterating further based on your guidance. I'm really learning a lot from this process—thanks for the review and the honest responses! |
northdpole
approved these changes
Jan 24, 2026
Collaborator
|
please resolve the conflicts and lets merge this |
PRAteek-singHWY
force-pushed
the
optimize-gap-analysis-pruning
branch
from
fc5bc3d to
3728d35
Compare
northdpole
approved these changes
Feb 14, 2026
PRAteek-singHWY
added a commit
to PRAteek-singHWY/OpenCRE
that referenced
this pull request
Feb 19, 2026
The toggle added in PR OWASP#717 was being overridden by a duplicate gap_analysis method left over from PR OWASP#716. Removed the duplicate so the feature toggle actually works as intended. Also adds scripts/benchmark_gap.py which proved the optimized mode is 99.5% faster and uses 99.6% less memory than the original. Closes OWASP#587
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked PR: This PR is built on top of PR #716 (Backend Optimization). Please merge #716 first.
Summary
This PR adjusts the categorization logic for Gap Analysis links in the frontend. It lowers the score threshold for "Weak" links from
20to7to better reflect the true quality of connections, as requested by the maintainers.Motivation
The maintainer noted:
Previously, a "Weak" link was defined as having a penalty score of
20or higher. This score is practically unreachable in normal operation (requires ~10 hops of "related" links), causing truly weak connections to be mislabeled as "Average" or "Strong". This change aligns the UI with the maintainer's request and the user's intuitive understanding of link strength.Changes
>= 20to>= 7.>= 20to>= 7.Related Issue
Verification
"Weakly connected likely to have small or no overlap"corresponds to score 7.Checklist