feat: Add smoke tests for copi.owasp.org and cornucopia.owasp.org (fi…#2069
feat: Add smoke tests for copi.owasp.org and cornucopia.owasp.org (fi…#2069sydseter merged 16 commits intoOWASP:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds smoke tests for the copi.owasp.org and cornucopia.owasp.org applications to verify basic functionality and availability of deployed services, addressing issue #1265.
Changes:
- Added smoke_tests.py with test classes for both applications to verify route accessibility and JavaScript functionality
- Added comprehensive README documentation for running and understanding the smoke tests
- Created dedicated smoke-tests.yaml workflow for scheduled and on-demand testing
- Integrated smoke tests into the existing run-tests.yaml workflow
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tests/scripts/smoke_tests.py | Implements smoke test classes for copi.owasp.org, cornucopia.owasp.org, and integration tests between both applications |
| tests/scripts/README.md | Provides documentation on what the smoke tests check, how to run them, and their CI/CD integration |
| .github/workflows/smoke-tests.yaml | Creates a dedicated workflow for running smoke tests on a schedule, manual trigger, or when application code changes |
| .github/workflows/run-tests.yaml | Integrates smoke tests into the main test suite that runs on pull requests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Sorry I havent' been able to get back to you sooner. Thank you for your effort. |
|
@sydseter Thanks for the feedback. I’ll update this PR so the smoke tests run only against the Dockerized copi app and database in the CI pipeline (localhost) and not production or stage, and I’ll remove the cornucopia.owasp.org smoke tests because Vite’s checks already validate those routes |
sydseter
left a comment
There was a problem hiding this comment.
Have a look at my comments.
…alhost - Removed all cornucopia.owasp.org smoke tests (Vite handles these) - Remove integration tests (tested both apps together) - Keept only CopiSmokeTests running against localhost:4000 - Updated workflow to provision Docker containers (PostgreSQL + copi app) - Update documentation to reflect localhost testing approach - Added container cleanup step to workflow OWASP#2069
|
@sydseter done, can you check it ? |
|
@sydseter Is this good to go ?? |
|
@sydseter Is this good to go ?? |
|
You still have commits that aren't verified. |
|
Your commits are still unsigned. git checkout -b test You commit should have a verified label like this: I am thinking that the reason you don't have a verified signature is because you are switching back and forth between your github accounts. Why are you doing that? First make sure that the email associated with your private signing key is verified with your github account: Go to https://github.com/settings/emails and make sure your email is listed there and verified. If not, make sure it is verified. If if you get an error saying that it is associated with another account, you will have two choices.
For more info on git commit signing see: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits You need to reset all the 21 commits you made like this:
|
…v, fix duplicate route, add helper methods
…alhost - Removed all cornucopia.owasp.org smoke tests (Vite handles these) - Remove integration tests (tested both apps together) - Keept only CopiSmokeTests running against localhost:4000 - Updated workflow to provision Docker containers (PostgreSQL + copi app) - Update documentation to reflect localhost testing approach - Added container cleanup step to workflow OWASP#2069
- Updated Python version from 3.11 to 3.12 in smoke-tests workflow - Remove unnecessary files: - SETUP_STATUS.ps1 - READY_TO_COMMIT.md - install-elixir-wsl.sh - install-elixir-d-drive.ps1 - IMPLEMENTATION_GUIDE.md - tests/scripts/README.md All changes are as per requested in PR review.
Smoke tests require Docker containers (copi app + database) which are only provisioned in the dedicated smoke-tests.yaml workflow. Removed from run-tests.yaml to prevent connection failures.
7bab8b5 to
7377ead
Compare
|
@sydseter done !! thankyou for helping me out !!, I am not switching between accounts but I do had another account which i havnt used or login for more than 2 - 3 years ,maybe that was the reason |
|
Yes, that quickly happens. It's a hazzle. |
|
@sydseter Is this under review ?, does it need any changes ? |
|
@immortal71 Thank you so much for you time! |

fixes #1265)