Skip to content

Conversation

@oncecelll
Copy link

@oncecelll oncecelll commented Jan 9, 2026

fix some struct field names in comment

category: docs
ticket: none

Signed-off-by: oncecelll <oncecell@outlook.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@KaloyanTanev KaloyanTanev added the merge when ready Indicates bulldozer bot may merge when all checks pass label Jan 9, 2026
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.94%. Comparing base (6426bd7) to head (b8fe9c6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4213      +/-   ##
==========================================
- Coverage   56.96%   56.94%   -0.02%     
==========================================
  Files         237      237              
  Lines       30622    30622              
==========================================
- Hits        17445    17439       -6     
- Misses      10945    10955      +10     
+ Partials     2232     2228       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oncecelll
Copy link
Author

It seems that the CI failure is unrelated to this change

Module: github.com/quic-go/quic-go
    Found in: github.com/quic-go/quic-go@v0.55.0
    Fixed in: github.com/quic-go/quic-go@v0.57.0
    Example traces found:
      #1: for function github.com/quic-go/quic-go/http3.ConfigureTLSConfig
        httpServeHook.Call @ github.com/obolnetwork/charon/app/app.go:1130:10
        Server.ListenAndServe @ stdlib/src/net/http/server.go:3389:16
        Server.Serve @ stdlib/src/net/http/server.go:3493:3
        conn.serve @ stdlib/src/net/http/server.go:1967:37
        Conn.HandshakeContext @ stdlib/src/crypto/tls/conn.go:1515:27
        Conn.handshakeContext @ stdlib/src/crypto/tls/conn.go:1575:32
        Conn.serverHandshake @ stdlib/src/crypto/tls/handshake_server.go:43:44
        Conn.readClientHello @ stdlib/src/crypto/tls/handshake_server.go:169:56
        ConfigureTLSConfig @ github.com/quic-go/quic-go/http3/server.go:62:29
        ConfigureTLSConfig @ github.com/quic-go/quic-go/http3/server.go:50:6

It should be necessary to upgrade the corresponding dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge when ready Indicates bulldozer bot may merge when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants