Skip to content

Conversation

@twerthi
Copy link
Contributor

@twerthi twerthi commented Feb 19, 2025


Background

The build log was being attached and not displayed in the final output of the step. It made sense to include it. In addition, there was already an if statement for $waitForComplete, I moved the code for attaching the log into this block and removed the new one I'd added previously.

Results

When $waitForComplete is true, the build log is now put in the output of the step.

Before

The build log was only being attached versus being displayed.

After

Build log is now displayed in the step if Wait for complete is checked.

Pre-requisites

  • Id should be a GUID that is not 00000000-0000-0000-0000-000000000000
    • NOTE If you are modifying an existing step template, please make sure that you do not modify the Id property (updating the Id will break the Library sync functionality in Octopus).
  • Version should be incremented, otherwise the integration with Octopus won't update the step template correctly
  • Parameter names should not start with $
  • Step template parameter names (the ones declared in the JSON, not the script body) should be prefixed with a namespace so that they are less likely to clash with other user-defined variables in Octopus (see this issue). For example, use an abbreviated name of the step template or the category of the step template).
  • LastModifiedBy field must be present, and (optionally) updated with the correct author
  • The best practices documented here have been applied
  • If a new Category has been created:
    • An image with the name {categoryname}.png must be present under the step-templates/logos folder
    • The switch in the humanize function in gulpfile.babel.js must have a case statement corresponding to it

Fixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line

@github-actions
Copy link

Start Hyponome locally

docker pull ghcr.io/hnrkndrssn/hyponome:main
docker run --rm -p 8000:8080 -it ghcr.io/hnrkndrssn/hyponome:main

Review in Hyponome

Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hnrkndrssn hnrkndrssn merged commit 4474475 into master Feb 19, 2025
3 checks passed
@hnrkndrssn hnrkndrssn deleted the update-jenkins-queue-job branch February 19, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants