Skip to content

Conversation

@harrisonmeister
Copy link
Contributor

Updates changes to the step template "Get Octopus Usage" reflected in OctopusDeploy/OctopusDeploy-Api#242

@github-actions
Copy link

Start Hyponome locally

docker pull ghcr.io/hnrkndrssn/hyponome:main
docker run --rm -p 8000:8080 -it ghcr.io/hnrkndrssn/hyponome:main

Review in Hyponome

Copy link
Contributor

@hnrkndrssn hnrkndrssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script configures the Security Protocol twice, which may not give the expected result:

# Add support for TLS 1.2
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor [System.Net.SecurityProtocolType]::Tls12
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor [System.Net.SecurityProtocolType]::Tls13

It should probably be updated to be on just the one statement if we want to ensure both TLS1.2 and TLS1.3 enabled:

# Add support for both TLS 1.2 and TLS 1.3
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12 -bor [System.Net.SecurityProtocolType]::Tls13

@harrisonmeister
Copy link
Contributor Author

Good catch @hnrkndrssn - I've made that update in 7478b57

It should probably be updated to be on just the one statement if we want to ensure both TLS1.2 and TLS1.3 enabled:

# Add support for both TLS 1.2 and TLS 1.3
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12 -bor [System.Net.SecurityProtocolType]::Tls13

@hnrkndrssn hnrkndrssn merged commit 613537a into master Aug 31, 2025
2 checks passed
@hnrkndrssn hnrkndrssn deleted the mh/get-usage-counts branch August 31, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants