This repository was archived by the owner on Jan 29, 2023. It is now read-only.
console: remove APP callbacks #899
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taimanhui
requested review from
dydysy,
huazhouwang,
shuaiLiWang and
somebodyLi
and removed request for
huazhouwang and
shuaiLiWang
huazhouwang
previously approved these changes
Aug 27, 2021
huazhouwang
reviewed
Aug 27, 2021
| util.register_callback(self._on_fee, ["fee"]) | ||
| # self.network.register_callback(self.on_fee_histogram, ['fee_histogram']) | ||
| util.register_callback(self._on_quotes, ["on_quotes"]) | ||
| util.register_callback(self._on_history, ["on_history"]) |
Author
There was a problem hiding this comment.
on_fee应该是实际上没作用的，但是也不和回调相关，不过我可以一起去掉
on_history看起来在wallet.py里面还有逻辑，虽然具体那个get_detailed_history我们没用到。
shuaiLiWang
previously approved these changes
Aug 27, 2021
taimanhui
dismissed stale reviews from shuaiLiWang and huazhouwang
via
d7a82de
taimanhui
force-pushed
the
remove-callback
branch
2 times, most recently
from
34c73a2 to
a4504b3
Compare
huazhouwang
previously approved these changes
Sep 17, 2021
shuaiLiWang
previously approved these changes
Sep 17, 2021
taimanhui
dismissed stale reviews from shuaiLiWang and huazhouwang
via
677fae6
taimanhui
force-pushed
the
remove-callback
branch
2 times, most recently
from
677fae6 to
189ee57
Compare
huazhouwang
previously approved these changes
Sep 23, 2021
taimanhui
force-pushed
the
remove-callback
branch
from
189ee57 to
ca86134
Compare
Signed-off-by: taimanhui <taimanhui@protonmail.com>
Signed-off-by: taimanhui <taimanhui@protonmail.com>
taimanhui
force-pushed
the
remove-callback
branch
from
ca86134 to
b6c7f4b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
清理掉callback
Does this close any currently open issues?
If it fixes a bug or resolves a feature request, be sure to link to that issue.
N/A
Pull request type
Put an
xin the boxes that applyWhere has this been tested?
No
Any other comments?
No