feat: IAMs now display when triggers added before first fetch #2528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Addresses issue where in-app messages wouldn't display on cold starts if their triggers were added very early (before IAM fetch completed). - Tracks triggers added before first fetch completes
Contributor
📊 Diff Coverage ReportDiff Coverage ReportThreshold: 80% Changed Files Coverage
Overall Coverage388/476 lines covered (81.5%) |
| private var hasCompletedFirstFetch: Boolean = false | ||
|
|
||
| // Tracks trigger keys added early on cold start (before first fetch completes), for redisplay logic | ||
| private val earlySessionTriggers: MutableSet<String> = mutableSetOf() |
Contributor
There was a problem hiding this comment.
should we make it concurrent? are we envisioning this to be cleared/added/updated at the same time?
| this.messages = newMessages as MutableList<InAppMessage> | ||
|
|
||
| // Apply isTriggerChanged for messages that match triggers added too early on cold start | ||
| if (earlySessionTriggers.isNotEmpty()) { |
Contributor
There was a problem hiding this comment.
is there a way to write a against this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Display IAMs with triggers added before first fetch on cold start.
Details
On subsequent cold starts, if triggers were added very early in the app lifecycle (before the first IAM fetch completed), in-app messages matching those triggers would not display even though they should have been eligible for redisplay.
Motivation
Product request
Scope
This only affects cold starts (process restarts) and does not impact warm starts from backgrounding, where existing redisplay behavior is preserved.
Testing
Unit testing
Need to add
Manual testing
Tested on API 35 emulator.
Add trigger immediately after initialization, and confirm the IAM now displays after the changes in this PR.
Tested with pausing and unpausing.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is