Automatically update link.xml by LinkerProcessor #547
Closed
+34
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
We can get rid of Generate link.xml step by using IUnityLinkProcessor which allows generate link.xml file during to build process.. It will simplify OneSignal setup process for end users and reduce count of generated files in project. Another one plus is if somewhere in future will necessary to update link.xml file, you can just update it without asking a users to regenerate link.xml file. |
fadi-george
force-pushed
the
main
branch
3 times, most recently
from
2667b0c to
2e8c527
Compare
Collaborator
|
Doesn't seem needed and pr seems pretty old so closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is