fix: NotEqualTo trigger no longer matches non-existent properties#1625
Merged
fix: NotEqualTo trigger no longer matches non-existent properties#1625
Conversation
- Changes the behavior of trigger evaluation when a property doesn't exist. - Previously, a trigger with NotEqualTo operator would return true for non-existent properties (e.g., subscription_type != "premium" would match users without any subscription_type set). - Now, only the NotExists operator returns true for non-existent properties. NotEqualTo requires the property to exist with a different value. - This provides stricter trigger matching where NotEqualTo only matches users who have explicitly set a value that differs from the trigger value.
fadi-george
approved these changes
Dec 22, 2025
abdulraqeeb33
approved these changes
Dec 23, 2025
abdulraqeeb33
left a comment
There was a problem hiding this comment.
this looks good to me @nan-li . Can we write some tests for this?
Merged
This was referenced Jan 9, 2026
This was referenced Jan 26, 2026
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
In-app "not_equal" trigger no longer matches non-existent properties.
Details
Motivation
NotEqualTooperator would return true for non-existent properties (e.g.,subscription_type != "premium"would match users without anysubscription_typeset).NotExistsoperator returns true for non-existent properties.NotEqualTorequires the property to exist with a different value.Motivation
Testing
Unit testing
Manual testing
iPhone 18.5 simulator
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is