fix: Retry IAM fetch when OneSignal ID becomes available#1626
Merged
Conversation
a8de502 to
a51d7f7
Compare
fadi-george
approved these changes
Dec 29, 2025
abdulraqeeb33
approved these changes
Jan 6, 2026
abdulraqeeb33
left a comment
There was a problem hiding this comment.
Is there a way you can write some tests?
When getInAppMessagesFromServer is called early in the app lifecycle while users are changing (e.g., login is called after initialize), the OneSignal ID may not be available yet, causing the fetch to fail silently. This fix ensures in-app messages are eventually fetched by: - Adding OSUserStateObserver to OSMessagingController - Storing the subscription ID when fetch fails due to missing OneSignal ID - Retrying the fetch when user state changes and OneSignal ID becomes available This prevents in-app messages from never being fetched when users are identified early in the app startup lifecycle.
7afc1b1 to
8f87f3c
Compare
Contributor
Author
Yes added in last commit |
8f87f3c to
012de36
Compare
* Add test class OSMessagingControllerUserStateTests * Update some existing test helpers
012de36 to
28f5639
Compare
Merged
This was referenced Jan 9, 2026
This was referenced Jan 26, 2026
This was referenced Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Retry IAM fetch when OneSignal ID becomes available if users change early in app startup.
Details
When getInAppMessagesFromServer is called early in the app lifecycle while users are changing (e.g., login is called after initialize), the OneSignal ID may not be available yet, causing the fetch to fail silently. This fix ensures in-app messages are eventually fetched by:
This prevents in-app messages from never being fetched when users are identified early in the app startup lifecycle.
Motivation
Fix bug reported when user switch early when app starts up, causing IAMs to not be fetched.
Scope
Testing
Unit testing
OSMessagingControllerUserStateTestsManual testing
Device: iOS 18.5 simulator
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is