fix: use locale-independent formatting for purchase prices#1634
Merged
Conversation
- Fixes an issue where purchase amounts were being formatted using the device's locale settings, causing European locales to send "12,99" instead of "12.99". This caused 400 errors from the API and blocked all user property updates. - The fix ensures the NSNumberFormatter uses en_US_POSIX locale, which always uses a period as the decimal separator regardless of device locale.
abdulraqeeb33
approved these changes
Jan 22, 2026
18 tasks
Merged
This was referenced Jan 28, 2026
This was referenced Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes an issue where purchase amounts were being formatted using the device's locale settings, causing European locales to send "12,99" instead of "12.99".
Details
NSNumberFormatterusesen_US_POSIXlocale, which always uses a period as the decimal separator regardless of device locale.Motivation
Scope
Testing
Unit testing
The callback productsRequest:didReceiveResponse: is an Apple API, so unable to mock with current test infra.
Manual testing
None
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is