feat: merge custom events into main for GA + tests#1636
Merged
Conversation
Motivation:
- previously it would log like this: "request failed with error: <OneSignalClientError: 0x600000cd49c0>
- now it will log like this: "request failed with error: <OneSignalClientError code: 202, message: Error parsing JSON, response: (null), underlyingError: Error Domain=NSCocoaErrorDomain Code=3840 "JSON text did not start with array or object and option to allow fragments not set. around line 1, column 0." UserInfo={NSDebugDescription=JSON text did not start with array or object and option to allow fragments not set. around line 1, column 0., NSJSONSerializationErrorIndex=0} >"
* No need to be on protocol nor exposed
* Add 2 buttons at the bottom of Dev App called "Track Named Event" for making a named event yourself and the other button "Track Preset Custom Events" sends a misc collection of events with different payloads * Add example custom events in Objective-C and Swift
nan-li
force-pushed
the
custom_events_ga
branch
from
55ac5d5 to
a52c5f1
Compare
Contributor
Author
@abdulraqeeb33 added to this PR in commit tests: add tests for custom events |
nan-li
changed the title
abdulraqeeb33
approved these changes
Jan 27, 2026
abdulraqeeb33
left a comment
abdulraqeeb33
left a comment
There was a problem hiding this comment.
Thank you for adding the tests @nan-li
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Merge #1552 into main.
Details
Motivation
For GA
Testing
Unit testing
Added in last commit
Manual testing
Run on iPhone 18.5 simulator testing custom events
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is