Skip to content

fix(iam): prevent crash when dismissing IAM during view hierarchy changes #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nan-li merged 1 commit into from
Feb 3, 2026
+8 −3
Merged

fix(iam): prevent crash when dismissing IAM during view hierarchy changes #1641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions iOS_SDK/OneSignalSDK/OneSignalInAppMessages/UI/OSInAppMessageViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,9 +516,14 @@ - (void)dismissCurrentInAppMessage:(BOOL)up withVelocity:(double)velocity {
if (self.dismissalTimer)
[self.dismissalTimer invalidate];

// If the rendering event never occurs any constraints being adjusted for dismissal will be nil
// and we should bypass dismissal adjustments and animations and skip straight to the OSMessagingController callback for dismissing
if (!self.didPageRenderingComplete) {
// Return early and skip constraint adjustments/animations if:
// - Page rendering never completed (constraints would be nil)
// - messageView is not valid or not a direct subview of self.view (prevents crashes when
// dismissal is triggered while the view hierarchy is in an inconsistent state)
if (!self.didPageRenderingComplete ||
!self.messageView ||
self.messageView.superview != self.view)
{
[self dismissViewControllerAnimated:false completion:nil];
[self.delegate messageViewControllerWasDismissed:self.message displayed:NO];
return;
Expand Down
Loading