Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
- Changed OSMacros.h visibility from Public to Private so the header won't be included in the public Headers folder during the build process - fix warning saying: "umbrella header for module 'OneSignalCore' does not include header 'OSMacros.h'"
Conventionally correct: Quoted imports (#import "OSMacros.h") are the standard pattern for private/internal headers, now that the OSMacros has been marked from public to private
5e57296 to
c866ecd
Compare
sherwinski
approved these changes
Feb 4, 2026
Merged
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix warning about umbrella header for module 'OneSignalCore' does not include header 'OSMacros.h' by changing its visibility to private.
Details
OSMacros.hwas in the public Headers folder of the framework, but it's not imported by the umbrella headerOneSignalCore.hand Clang expects all public headers to be included by that umbrella header.How this change was tested
Motivation
Reported warning internally
Scope
build process and annoying warnings
Testing
Unit testing
None needed
Manual testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is