Open
Conversation
soxofaan
reviewed
Dec 17, 2025
Member
soxofaan
left a comment
soxofaan
left a comment
There was a problem hiding this comment.
some more quick notes I managed to squeeze in
Member
I think there is something wrong with this feature branch or pull request (rebase gone wrong?) |
Contributor
Author
|
oh that is odd, will indeed cherrypick and redo the rebase |
HansVRP
force-pushed
the
issue816_threadeddownload
branch
from
3234f4f to
597997f
Compare
…rs; this can be used to guarantee the download gets finished
…'; similarly download shutdown depend on optional download
HansVRP
force-pushed
the
issue816_threadeddownload
branch
from
597997f to
c999d1f
Compare
Contributor
Author
|
@soxofaan apologies for not noticing myself, branch is back in order |
Contributor
Author
|
good to merge @soxofaan ? |
soxofaan
reviewed
Jan 23, 2026
Contributor
Author
|
@soxofaan good to rereview or merge if you agree. I did notice in my previous commit some latency when managing the multiple pools (see failed unit test) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.