Implement Jackson3 support and maintain Jackson2 support

[smals-mavh]

Summary by cubic

Add Jackson 3 support alongside Jackson 2 so JsonNullable works on both runtimes. This introduces a Jackson3 module with serializers/deserializers and refactors the Jackson2 implementation to keep compatibility.

• New Features

  • Jackson 3: JsonNullableJackson3Module with serializers, deserializers, type/value serializer modifiers, and unwrapping writer.
  • Auto-discovery for Jackson 3 via META-INF/services/tools.jackson.databind.JacksonModule.
  • Test coverage for both versions using Jackson2Processor and Jackson3Processor with parameterized tests.

• Refactors

  • Renamed Jackson 2 classes to JsonNullableJackson2* and wired JsonNullableModule to these implementations.
  • Split BOMs in pom.xml (jackson2-bom and jackson3-bom) and updated module-info and service-loading tests.

^{Written for commit 00bf11d. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 36 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="pom.xml">

<violation number="1" location="pom.xml:40">
P2: Jackson 3 requires Java 17+, but the build is pinned to Java 8. Adding the Jackson 3 BOM/tools.jackson dependencies will make builds fail with class file version incompatibility unless the toolchain is upgraded or Jackson 3 is isolated.</violation>
</file>

---

Since this is your first cubic review, here's how it works:

• cubic automatically reviews your code and comments on bugs and improvements
• Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
• Ask questions if you need clarification on any suggestion

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P2: Jackson 3 requires Java 17+, but the build is pinned to Java 8. Adding the Jackson 3 BOM/tools.jackson dependencies will make builds fail with class file version incompatibility unless the toolchain is upgraded or Jackson 3 is isolated.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At pom.xml, line 40:

<comment>Jackson 3 requires Java 17+, but the build is pinned to Java 8. Adding the Jackson 3 BOM/tools.jackson dependencies will make builds fail with class file version incompatibility unless the toolchain is upgraded or Jackson 3 is isolated.</comment>

<file context>
@@ -36,7 +36,8 @@
         <hibernate-validator.version>7.0.5.Final</hibernate-validator.version>
-        <jackson-bom.version>2.20.1</jackson-bom.version>
+        <jackson2-bom.version>2.20.1</jackson2-bom.version>
+        <jackson3-bom.version>3.0.4</jackson3-bom.version>
         <javax-validation-api.version>2.0.1.Final</javax-validation-api.version>
         <jakarta-validation-api.version>3.1.1</jakarta-validation-api.version>
</file context>

[smals-mavh]

This is a fair point, however, locally I was able to build (and use) this without any issue. (Obviously I have JDK21 installed, but the maven build had no issues with java.version set to 8)

[pvdbosch]

I guess the .github/workflows should be updated then to JDK17

[smals-mavh]

Some extra context:

• Kept the name 'JsonNullableModule' instead of JsonNullableJackson2Module for example to keep some backwards compatibility
• The jackson library is marked as 'provided' in the pom now (to not have any jackson version conflicts downstream). The disadvantage is that users now need to add jackson to their pom.
  • On that note, we could add jackson-annotations since they're the same for both Jackson2 and Jackson3 for the moment. But might not be super future proof.
• Parameterized tests are a bit shoe-horned in some places, but to me this seemed to be the 'safest' route to make sure that all tests work with both Jackson versions.
• Tested in both Spring Boot 3 and Spring Boot 4 projects and had no issues (apart from having to add the jackson libs myself since they're not transitive anymore)

[SirBigoo]

I'm waiting this PR to be released because I can't migrate to spring 4 without breaking my app behavior... 💯

[pvdbosch]

I guess the .github/workflows should be updated then to JDK17

[pvdbosch]

module name impacted by jackson2->3, so both should probably become optional dependencies:

requires static com.fasterxml.jackson.databind;
requires static tools.jackson.databind;

[pvdbosch]

should add jackson3 module as well