Skip to content

Improve aliases for Pydantic models #22708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blubber wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

Improve aliases for Pydantic models #22708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...tor/src/main/java/org/openapitools/codegen/languages/AbstractPythonPydanticV1Codegen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,7 +908,8 @@ private ModelsMap postProcessModelsMap(ModelsMap objs) {

// field
if (cp.baseName != null && !cp.baseName.equals(cp.name)) { // base name not the same as name
fields.add(String.format(Locale.ROOT, "alias=\"%s\"", cp.baseName));
fields.add(String.format(Locale.ROOT, "validation_alias=\"%s\"", cp.baseName));
fields.add(String.format(Locale.ROOT, "serialization_alias=\"%s\"", cp.baseName));
Comment on lines +911 to +912
Copy link

@cubic-dev-ai cubic-dev-ai bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Pydantic v1 generator emits v2-only Field kwargs (validation_alias/serialization_alias), causing runtime TypeError and alias breakage.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPythonPydanticV1Codegen.java, line 911:

<comment>Pydantic v1 generator emits v2-only Field kwargs (`validation_alias`/`serialization_alias`), causing runtime TypeError and alias breakage.</comment>

<file context>
@@ -908,7 +908,8 @@ private ModelsMap postProcessModelsMap(ModelsMap objs) {
                 // field
                 if (cp.baseName != null && !cp.baseName.equals(cp.name)) { // base name not the same as name
-                    fields.add(String.format(Locale.ROOT, "alias=\"%s\"", cp.baseName));
+                    fields.add(String.format(Locale.ROOT, "validation_alias=\"%s\"", cp.baseName));
+                    fields.add(String.format(Locale.ROOT, "serialization_alias=\"%s\"", cp.baseName));
                 }
</file context>
Suggested change
fields.add(String.format(Locale.ROOT, "validation_alias=\"%s\"", cp.baseName));
fields.add(String.format(Locale.ROOT, "serialization_alias=\"%s\"", cp.baseName));
fields.add(String.format(Locale.ROOT, "alias=\"%s\"", cp.baseName));

}

if (!StringUtils.isEmpty(cp.description)) { // has description
Expand Down