ENH: add support for PEP 735 dependency-groups via a new workflow input test_groups
#286
Conversation
neutrinoceros
force-pushed
the
enh/pep735-support
branch
5 times, most recently
from
366158b to
afae441
Compare
|
Failure on MacOs seems weird enough that I'm considering it could be a fluke, but failures on Linux are even bigger head-scratchers to me. It seems hardly related to what I'm doing, has this happened before ? |
|
upstream bug fix at OpenAstronomy/build-python-dist#23 |
neutrinoceros
force-pushed
the
enh/pep735-support
branch
from
768cc2a to
1e745d2
Compare
|
I was able to confirm that failures are real as I can run the test workflows successfully on my fork using the main branch. |
neutrinoceros
force-pushed
the
enh/pep735-support
branch
2 times, most recently
from
2debe85 to
1557367
Compare
|
I don't understand why cibuildwheel + manylinux jobs are still failing. Maybe I just need to put it to rest and come back later with a fresh eye. |
| [tool.cibuildwheel.linux] | ||
| environment-pass = ["GITHUB_WORKFLOW"] |
There was a problem hiding this comment.
I think the Linux errors are due to this part being removed. It's used in setup.py to include the C extension for the publish workflow tests – I'm guessing env vars must always be passed on Windows and macOS.
There was a problem hiding this comment.
oh my... that's completely unintentional and I still missed it when I self-reviewed. Let's try cleaning it up. Thank you !
neutrinoceros
force-pushed
the
enh/pep735-support
branch
from
839ee5b to
58fee54
Compare
neutrinoceros
force-pushed
the
enh/pep735-support
branch
2 times, most recently
from
1739e6a to
9ee357a
Compare
neutrinoceros
force-pushed
the
enh/pep735-support
branch
from
9c7e043 to
848e825
Compare
|
Thanks @neutrinoceros! Here's the new release: https://github.com/OpenAstronomy/github-actions-workflows/releases/tag/v2.1.0 |
2 participants
This will require OpenAstronomy/build-python-dist#21