Skip to content

Conversation

@neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Oct 12, 2025

The main motivation for rushing this manual PR are fixes from cibuildwheel 3.2.1. I also included configuration tweaks needed for CI to survive running on cibuildwheel 3.2.x, where free-threaded builds for 3.14 are included by default.

close #312

@neutrinoceros
Copy link
Contributor Author

(somwhat cool that I got PR number 314 for this one)

[[tool.cibuildwheel.overrides]]
select = "cp3*t-*"
inherit.environment = "append"
environment = {"PYTHON_GIL" = "0"}
Copy link
Member

@Cadair Cadair Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we should enable by default in the tox & publish workflows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if you want to somehow make every user treat warnings as errors. Seriously though: please don't 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(To be clear: I only use this to get by a warning saying that the GIL is re-enabled when importing test extensions, since they aren't marked as free-threading compatible, but downstream should be free to set this up themselves if and only if they want or need to)

@Cadair Cadair merged commit 930ac90 into OpenAstronomy:main Oct 13, 2025
77 checks passed
@Cadair
Copy link
Member

Cadair commented Oct 13, 2025

Released

@neutrinoceros neutrinoceros deleted the mnt/upgrade-gha branch October 13, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants