-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Feat/Dev tools and centralising model name in YAML files #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
NA-Wen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi LaansDole,
Thank you so much for this wonderful contribution! I really appreciate the time and effort you've put into improving the developer experience with the new Makefile, dev tools, and documentation updates.
I've reviewed the PR and most of the changes look great. However, I'd like to kindly suggest a few adjustments:
1. Changes to check/check.py
Would it be possible to revert the modifications to check/check.py? It seems these changes might not be directly related to the main goals of this PR.
2. Modifications to yaml_instance/ files
I'd like to respectfully ask if we could revert the changes to the YAML files in the yaml_instance/ directory. The reason is that we intentionally designed the system to allow users the flexibility to specify different model names for different agents directly in their YAML configurations. By using a centralized .env variable, we might limit this flexibility. We believe giving users more control over individual agent configurations is important for the project's use cases.
Would you be able to update the PR to address these points? I'm really excited about merging the core improvements you've made. Thank you again for your contribution and understanding! 😊
I have reverted as per your suggestions |
README.mdwithmakecommands fromMakefile${MODEL_NAME}in YAML Files to centralised model name from.env.envwith.env.exampleand hide.envin.gitignore, which is a better practice because why not