Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

[client] do not register API listening URI when using AMQP protocol#867

Merged
labo-flg merged 1 commit intomasterfrom
oob/fix_listening_on_amqp_protocol
Apr 1, 2025
Merged

[client] do not register API listening URI when using AMQP protocol#867
labo-flg merged 1 commit intomasterfrom
oob/fix_listening_on_amqp_protocol

Conversation

@sbocahu
Copy link
Member

@sbocahu sbocahu commented Apr 1, 2025

Proposed changes

  • OpenCTIConnector last argument is listen_callback_uri with default value None, which needs to be set when using protocol API instead of default AMQP. However, previous code in the connector helper always sets the argument to an URL based on two other config variables with default values, resulting in all connectors registering with a listen_callback_uri. The protocol is not kept in OpenCTI and the workers check listen_callback_uri to determine if they need to connect to the URI. All connectors are then trying to reach the default URI when using AMQP protocol.
    This change fixes it by setting the listen_callback_uri argument only if API protocol.
  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@sbocahu sbocahu added the filigran team use to identify PR from the Filigran team label Apr 1, 2025
@labo-flg labo-flg added the multi-repository When a PR requires several repository changes label Apr 1, 2025
@labo-flg
Copy link
Member

labo-flg commented Apr 1, 2025

Please black . in your sources to format the code and we're good.

@sbocahu sbocahu force-pushed the oob/fix_listening_on_amqp_protocol branch from 5311515 to bafd874 Compare April 1, 2025 14:43
@labo-flg labo-flg removed the multi-repository When a PR requires several repository changes label Apr 1, 2025
@labo-flg labo-flg merged commit f2d44b5 into master Apr 1, 2025
6 checks passed
@labo-flg labo-flg deleted the oob/fix_listening_on_amqp_protocol branch April 1, 2025 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants