Issue/108 #192
Merged
Issue/108 #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
thirtytwobits
force-pushed
the
issue/108
branch
4 times, most recently
from
e41233b to
bdb5407
Compare
thirtytwobits
force-pushed
the
issue/108
branch
from
bdb5407 to
caa3c9a
Compare
thirtytwobits
force-pushed
the
issue/108
branch
from
748f010 to
3a7b1a9
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for SonarQube static code analysis by adding SonarQube configuration, updating project version numbers, and improving debug assertion checks across the codebase.
- Adds comprehensive SonarQube configuration with code analysis rules and suppressions
- Bumps CETL version from 1.4.2 to 1.5.0
- Modernizes debug assertion checks to use explicit macro checking pattern
Reviewed Changes
Copilot reviewed 26 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| sonar-project.properties | New SonarQube configuration file defining project settings, source paths, and analysis rules |
| include/cetl/pmr/o1heap_memory_resource_delegate.hpp | Updates o1heap integration with new API usage and SonarQube suppressions |
| include/cetl/cetl.hpp | Version bump to 1.5.0 and SonarQube comment suppressions |
| cetlvast/suites/unittest/*.cpp | Updates debug assertion checks to use explicit macro checking pattern |
| .vscode/* | VS Code configuration updates for SonarLint integration |
| .github/workflows/* | GitHub Actions updates for SonarQube integration |
| cetlvast/cmake/modules/* | CMake module cleanups and SonarScanner removal |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
thirtytwobits
force-pushed
the
issue/108
branch
from
3a7b1a9 to
ac55191
Compare
improving some coverage, cleaning up a few sonarlint issues, and steering vscode users to clangd. Consuming fixes in o1Heap and added o1heap example. Bump SonarSource/sonarqube-scan-action from 5.3.0 to 5.3.1 Bumps [SonarSource/sonarqube-scan-action](https://github.com/sonarsource/sonarqube-scan-action) from 5.3.0 to 5.3.1. - [Release notes](https://github.com/sonarsource/sonarqube-scan-action/releases) - [Commits](SonarSource/sonarqube-scan-action@v5.3.0...v5.3.1) --- updated-dependencies: - dependency-name: SonarSource/sonarqube-scan-action dependency-version: 5.3.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Bump actions/upload-pages-artifact from 3 to 4 Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-pages-artifact/releases) - [Commits](actions/upload-pages-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-pages-artifact dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
thirtytwobits
force-pushed
the
issue/108
branch
from
ac55191 to
5b56bcc
Compare
|
pavel-kirienko
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.