Ensure GPIO pins are reset when used by a I2C {master, slave}, UART and ADC #355
+277
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrysxie
added
enhancement
Wassasin
force-pushed
the
feature/drop-for-gpio
branch
3 times, most recently
from
4308137 to
7cbaa1a
Compare
jamesmunns
approved these changes
Apr 7, 2025
Wassasin
force-pushed
the
feature/drop-for-gpio
branch
2 times, most recently
from
60943f2 to
89f7de2
Compare
Contributor
|
@JamesHuard , @felipebalbi can you guys please review and provide feedback? Thanks. |
Contributor
|
@RobertZ2011 can you guys please review and provide feedback? Thanks. |
felipebalbi
previously approved these changes
May 20, 2025
Wassasin
force-pushed
the
feature/drop-for-gpio
branch
from
89f7de2 to
15f92eb
Compare
Wassasin
force-pushed
the
feature/drop-for-gpio
branch
from
15f92eb to
d5575fd
Compare
Wassasin
requested review from
JamesHuard,
RobertZ2011,
jerrysxie,
madeleyneVaca and
tullom
as code owners
jeffglaum
modified the milestones:
IMXRT HAL Code Quality and Enhancements,
0. IMXRT HAL Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the first step towards implementing
Dropfor all drivers, have the drivers own an instance of aPindriver which takes care of resetting each pin when the parent peripheral driver is dropped.A subsequent PR will tackle Flexcomm disable/reset for each peripheral.
I took care to change as little as possible. Ideally low level
Sealedimplementations are separated from high level embassy driver implementations. Currently this distinction is a bit blurry, and consequently a driver can be a bit messy. Good examples of these are theSdaPinandCtsPintraits and friends. The separation betweengpioandiopctlcould also be better.IopctlPintraits should be private.Have not yet tested this PR on the EVK, as we are waiting for those to be delivered. I will update this PR once it has been tested.