Use the embedded-hal-i2c traits for i2c targets #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main motivators are: - More consistent interface that is better misuse resistant. - Easier to extend with support for Automatic Ack/Nack of addresses in async variant. - Better support for cancelation and capable of better surfacing what the hardware can actually do. The code changes also fixes some issues in 10-bit addressing. It should now match the behaviour specified in UM10204
This is done through the expect_read and expect_write interfaces, as automatic acknowledgement requires the dma to be in place beforehand.
This register contains both write-to-trigger bits and bits that represent semi-permanent state. This commit ensures we don't accidentaly write 1s to the write-to-trigger bits, as the hardware doesn't clear these automatically.
Cargo Vet Audit Passed
|
davidv1992
force-pushed
the
i2c-target-trait
branch
from
bb458c3 to
9d7673e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this pull request is an addition to #389. I can't easily make it display the diff here properly until that PR is merged however. Only the last commit is new.