Implemented tests for missing functionalities in FileClientImpl.createFile() #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eFile() Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
| .thenReturn(fileCreateResult); | ||
| when(fileCreateResult.fileId()).thenReturn(fileId); | ||
| when(protocolLayerClient.executeFileAppendRequestTransaction(any(FileAppendRequest.class))) | ||
| .thenReturn(any(FileAppendResult.class)); |
Member
There was a problem hiding this comment.
I would suggest we avoid any() in when for Return Type since thenReturn expects a specific object. Replace it with a mocked FileAppendResult object
final FileAppendResult fileAppendResult = Mockito.mock(FileAppendResult.class);
when(protocolLayerClient.executeFileAppendRequestTransaction(any(FileAppendRequest.class))) .thenReturn(fileAppendResult);
| import java.time.Instant; | ||
|
|
||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.Mockito.*; |
Member
There was a problem hiding this comment.
Remove the asterisk wildcard
hiero-enterprise-base/src/test/java/com/openelements/hiero/base/test/FileClientImplTest.java
Show resolved
Hide resolved
Member
|
Thanks for working on this @manishdait! Just a few main comments! |
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented test to validate the functionality of the
createFile()method within theFileClientImplclass, covering both successful and failure scenarios.Closes: #99