Skip to content

Fix duplicateExit authorization bypass #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwsantiago wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix duplicateExit authorization bypass #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/servers/CNLoginServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,17 +595,15 @@ void CNLoginServer::changeName(CNSocket* sock, CNPacketData* data) {
}

void CNLoginServer::duplicateExit(CNSocket* sock, CNPacketData* data) {
// TODO: FIX THIS PACKET

sP_CL2LS_REQ_PC_EXIT_DUPLICATE* exit = (sP_CL2LS_REQ_PC_EXIT_DUPLICATE*)data->buf;
Database::Account account = {};
Database::findAccount(&account, AUTOU16TOU8(exit->szID));

// sanity check
if (account.AccountID == 0) {
std::cout << "[WARN] P_CL2LS_REQ_PC_EXIT_DUPLICATE submitted unknown username: " << exit->szID << std::endl;
if (account.AccountID == 0)
return;

if (loginSessions.find(sock) == loginSessions.end() || loginSessions[sock].userID != account.AccountID)
return;
}

exitDuplicate(account.AccountID);
}
Expand Down