fixed memory leak in openDevice #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
For the moment, could you just add a comment in |
Contributor
Author
|
done. |
Contributor
|
While we're on the subject of memory mangement, you could also add a comment on the |
Contributor
Author
|
There are probably some more parts where comments are useful. But this is out of the focus of this PR. |
Contributor
|
OK, merged. We'll probably need another comments/docs PR anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a memory leak in
Freenect2::openDevice.If it fails before line 740 the PacketPipeline will not be deleted. It could also happen when passing a wrong serial number.
If it fails after line 740 the PacketPipeline will be deleted by the destructor of
Freenect2DeviceImpl.I added the necessary delete instructions. We should note somewhere in the documentation that libfreenect2 takes over control of the pipeline object (including destruction) and that it should never be used or deleted by user code afterwards.