Skip to content

fix(fs/remove): add validation for empty items in delete file list #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
datao2001 wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −0
Open

fix(fs/remove): add validation for empty items in delete file list #1617

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcc56cc
fix(FsRemove): add validation for empty items in delete file list
datao2001 Nov 11, 2025
806301b
Merge branch 'main' into fix-fs-remove
PIKACHUIM Dec 15, 2025
9beb430
fix(FsRemove): enhance validation to prevent unintended directory del…
datao2001 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions server/handles/fsmanage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,11 @@ func FsRemove(c *gin.Context) {
return
}
for _, name := range req.Names {
// Skip invalid item names (empty string, whitespace, ".", "/","\t\t","..") to prevent accidental removal of current directory
if strings.TrimSpace(utils.FixAndCleanPath(name)) == "/" {
utils.Log.Warnf("FsRemove: invalid item skipped: %s (parent directory: %s)\n", name, reqDir)
continue
}
err := fs.Remove(c.Request.Context(), stdpath.Join(reqDir, name))
if err != nil {
common.ErrorResp(c, err, 500)
Expand Down