fix(setting): handle delete of setting item with empty key#2131
Open
j2rong4cn wants to merge 1 commit intoOpenListTeam:mainfrom
Open
fix(setting): handle delete of setting item with empty key#2131j2rong4cn wants to merge 1 commit intoOpenListTeam:mainfrom
j2rong4cn wants to merge 1 commit intoOpenListTeam:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where deleting a setting item caused a "UNIQUE constraint failed" error (issue #2127), which resulted in a 502 response and prevented the server from restarting. The fix addresses both the immediate delete issue and adds preventive cleanup for corrupted data.
Changes:
- Modified the
DeleteSettingItemByKeyfunction to use an explicit WHERE clause instead of relying on GORM's implicit primary key handling - Added cleanup logic during bootstrap to detect and remove setting items with empty keys
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/db/settingitem.go | Changed delete implementation to use explicit WHERE clause with columnName() helper, making it consistent with other database operations in the file |
| internal/bootstrap/data/setting.go | Added check to detect and clean up corrupted setting items with empty keys during initialization, preventing them from causing issues later |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context / 背景
Close #2127
How Has This Been Tested? / 测试
Checklist / 检查清单
我已阅读 CONTRIBUTING 文档。
go fmtor prettier.我已使用
go fmt或 prettier 格式化提交的代码。我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
我已相应更新了相关仓库(若适用)。