Skip to content

fix(setting): handle delete of setting item with empty key#2131

Open
j2rong4cn wants to merge 1 commit intoOpenListTeam:mainfrom
j2rong4cn:pr/fix9
Open

fix(setting): handle delete of setting item with empty key#2131
j2rong4cn wants to merge 1 commit intoOpenListTeam:mainfrom
j2rong4cn:pr/fix9

Conversation

@j2rong4cn
Copy link
Member

Motivation and Context / 背景

Close #2127

How Has This Been Tested? / 测试

Checklist / 检查清单

  • I have read the CONTRIBUTING document.
    我已阅读 CONTRIBUTING 文档。
  • I have formatted my code with go fmt or prettier.
    我已使用 go fmtprettier 格式化提交的代码。
  • I have added appropriate labels to this PR (or mentioned needed labels in the description if lacking permissions).
    我已为此 PR 添加了适当的标签(如无权限或需要的标签不存在,请在描述中说明,管理员将后续处理)。
  • I have requested review from relevant code authors using the "Request review" feature when applicable.
    我已在适当情况下使用"Request review"功能请求相关代码作者进行审查。
  • I have updated the repository accordingly (If it’s needed).
    我已相应更新了相关仓库(若适用)。

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where deleting a setting item caused a "UNIQUE constraint failed" error (issue #2127), which resulted in a 502 response and prevented the server from restarting. The fix addresses both the immediate delete issue and adds preventive cleanup for corrupted data.

Changes:

  • Modified the DeleteSettingItemByKey function to use an explicit WHERE clause instead of relying on GORM's implicit primary key handling
  • Added cleanup logic during bootstrap to detect and remove setting items with empty keys

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
internal/db/settingitem.go Changed delete implementation to use explicit WHERE clause with columnName() helper, making it consistent with other database operations in the file
internal/bootstrap/data/setting.go Added check to detect and clean up corrupted setting items with empty keys during initialization, preventing them from causing issues later

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 调用删除key接口后返回502且无法再启动

2 participants

Comments