Skip to content

fix: convert boundary_ratio from timestep space to index space via inverse sigma_shift #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Auraithm wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −2
Open

fix: convert boundary_ratio from timestep space to index space via inverse sigma_shift #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93110ce
fix: convert boundary_ratio from timestep space to index space via in…
Auraithm Feb 13, 2026
48e6c3b
fix: use table lookup for boundary index instead of inverse sigma_shi…
Auraithm Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions mova/diffusion/pipelines/mova_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,10 +1386,13 @@ def training_step(
mode_scale=1.0,
independent_timesteps=False,
)
# Look up the index boundary directly from the scheduler's timestep table.
# boundary_ratio=0.9 means timestep 900; count how many timesteps >= 900 to get the index fraction.
boundary = (self.scheduler.timesteps >= self.boundary_ratio * self.scheduler.num_train_timesteps).sum().item() / self.scheduler.num_train_timesteps
if global_step % 2 == 0:
timestep_config.max_timestep_boundary = self.boundary_ratio
timestep_config.max_timestep_boundary = boundary
else:
timestep_config.min_timestep_boundary = self.boundary_ratio
timestep_config.min_timestep_boundary = boundary

timestep, audio_timestep = self.sample_timestep_pair(timestep_config)
timestep = timestep.to(device=device)
Expand Down