Conversation
tinova
requested review from
Aletibazo and
ArnauGabrielAtienza
and removed request for
tinova
| - hosts: "{{ frontend_group | d('frontend') }}" | ||
| roles: | ||
| - role: validation | ||
|
|
There was a problem hiding this comment.
No need for this playbook, the validation role is already invoked in the main validation.yml playbook
There was a problem hiding this comment.
The basic idea is to run those optional networkings tests in scope of generic validation framework. So those tests are part of the validation role
| ansible.builtin.include_tasks: | ||
| file: "{{ role_path }}/tasks/networks_verification.yml" | ||
| when: validation.networks_verification | ||
|
|
There was a problem hiding this comment.
Maybe we should create a specific role for this network task and change the validation role into a different name like services. Just a suggestion.
There was a problem hiding this comment.
this relates to the comment above: The basic idea is to run those optional networkings tests in scope of generic validation framework. So those tests are part of the validation role originally. However not a big deal to split them out.
|
@ArnauGabrielAtienza , @roamingengineer311 please review the latest commit per discussion we had |
There was a problem hiding this comment.
I haven't tested it yet, but i suggest to move everything to main.yml since role looks like completed and if we want to add something we will add to the code of a main.yml
There was a problem hiding this comment.
done in the latest commit
|
@ArnauGabrielAtienza , @Aletibazo, please review |
|
3 participants
Network verification tests performing the following tests: