Js chores #128
Open
Js chores #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristramg
force-pushed
the
js_chores
branch
2 times, most recently
from
e72cfeb to
9e61191
Compare
Signed-off-by: Tristram Gräbener <tristram+git@tristramg.eu>
Signed-off-by: Tristram Gräbener <tristram+git@tristramg.eu>
Signed-off-by: Tristram Gräbener <tristram+git@tristramg.eu>
Signed-off-by: Tristram Gräbener <tristram+git@tristramg.eu>
Tristramg
force-pushed
the
js_chores
branch
2 times, most recently
from
553cd6c to
b7d8a61
Compare
So we do a manual conversion to an object Signed-off-by: Tristram Gräbener <tristram+git@tristramg.eu>
woshilapin
approved these changes
Dec 18, 2025
Contributor
woshilapin
left a comment
woshilapin
left a comment
There was a problem hiding this comment.
The last commit is weird, but I’m not sure I have the competence to investigate. Maybe get some help from some frontend developer?
Contributor
Author
|
My understanding that it comes from maplibre/maplibre-gl-js#6702 : the objects are no longer stringyfied when sent to an other worker and it breaks some kind of thread safety (not sure in general) That change was introduced in https://github.com/maplibre/maplibre-gl-js/releases/tag/v5.13.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.