editoast, core: include train name in generated debug data #14493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eloi Charpentier <eloi.charpentier.42@gmail.com>
github-actions
bot
added
area:front
Contributor
|
eckter
changed the title
eckter
force-pushed
the
ech/add-train-names
branch
2 times, most recently
from
1a25262 to
34592ae
Compare
Signed-off-by: Eloi Charpentier <eloi.charpentier.42@gmail.com>
eckter
force-pushed
the
ech/add-train-names
branch
from
34592ae to
c3cf5f7
Compare
flomonster
approved these changes
Dec 19, 2025
Member
flomonster
left a comment
flomonster
left a comment
There was a problem hiding this comment.
Thanks for this PR.
It will be very nice to not merge this today since we're trying to merge this one: #14371 🙏
| #[schema(as = core::TrainRequirementsById)] | ||
| pub struct TrainRequirementsById { | ||
| pub train_id: String, | ||
| pub train_name: String, |
Member
There was a problem hiding this comment.
Fine with that can we just indicate that it's for debuging as comment or doc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13831, that's the last required part.
Apparently adding data to an editoast endpoint for the purpose of viewing and understanding the results is controversial. I'll still mark this PR as ready to review as I'd want to discuss it and, if necessary, talk about alternatives.