osrd-schemas: fix standard (prev. linear) allowance name to match editoast's one #14498
+115
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bougue-pe
requested review from
Castavo and
shenriotpro
and removed request for
shenriotpro
github-actions
bot
added
area:railjson
LINEAR is not matching editoast's API (only used in core AFAIK) Signed-off-by: Pierre-Etienne Bougué <bougue.pe@proton.me>
after osrd-schemas' bump in previous PR Signed-off-by: Pierre-Etienne Bougué <bougue.pe@proton.me>
bougue-pe
force-pushed
the
peb/osrd_schemas/fix_standard_allowance
branch
from
d0d19c6 to
6c49882
Compare
Contributor
|
Sounds like we should update version numbers? |
Contributor
Author
OK to bump, just waiting to make sure this change is the solution we want. |
Contributor
|
I don't think much can be argued against moving Rewriting the API would indeed be a lot of work, even though it would make sense. We can always approve and merge this right now and plan for the rewrite of the api later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINEARis not matching editoast's API (only used in core AFAIK), so this is the smallest modification possible for consistency.Although,
STANDARDis not a good name IMO as it doesn't carry precise meaning (liketypeorcategoryfor example),LINEARis better in that regard (but way more changes are necessary).Client I know of is already using
STANDARD, with own (😓) model instead of osrd-schemas for that.