front: fix process xml error #14506
Open
front: fix process xml error #14506
+14
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alice K. <alice.khoudli@gmail.com>
Signed-off-by: Alice K. <alice.khoudli@gmail.com>
achrafmohye
approved these changes
Dec 22, 2025
Contributor
achrafmohye
left a comment
achrafmohye
left a comment
There was a problem hiding this comment.
LGTM as is. @Castavo @SharglutDev, what are your thoughts on the behavior when both tartine and local import fail?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed by @Castavo , xml parsing errors were not surfaced to users when parsing locally. Worse, it prevented the tartine error from being displayed.
One question, is if the tartine and local import both fail, should both errors be displayed? If not, which one do we want to display?