Update dispatcher.php #277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the require() on line 270 makes calls to mi_command() which passes the $errors variable by reference. This then gets passed all over the place and is expected to be an array, not a string. Array initialisation on line 269 is required because $errors is defined as a string previously, this causes a type error when you try to load the dispatcher page: PHP Fatal error: Uncaught Error: [] operator not supported for strings
Contributor
Author
|
@liviuchircu any chance this could be merged? |
Member
|
Hey, @petekelly! Good catch there. Still, won't your fix cause issues a couple lines below, due to the string concatenation bit which your patch now breaks (😊), possibly with PHP errors resembling: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the require() on line 270 makes calls to mi_command() which passes the $errors variable by reference.
This then gets passed all over the place and is expected to be an array, not a string.
Array initialisation on line 269 is required because $errors is defined as a string previously, this causes a type error when you try to load the dispatcher page:
PHP Fatal error: Uncaught Error: [] operator not supported for strings