Skip to content

Fix multiple rule bugs #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmai merged 3 commits into from
Sep 25, 2025
Merged

Fix multiple rule bugs #868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce4841a
Fix logical lane rule
thomassedlmayer Jul 22, 2025
c33a57d
Remove incorrect rules
thomassedlmayer Jul 22, 2025
1a9342c
Fix rule syntax in sensor view
thomassedlmayer Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions osi_lane.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,13 +748,6 @@ message LaneBoundary
// \attention For \c BoundaryPoint the same rule for the approximation
// error applies as for \c Lane::Classification::centerline.
//
// \rules
// first_element width is_equal_to 0.13
// first_element height is_equal_to 0.14
// last_element width is_equal_to 0.13
// last_element height is_equal_to 0.13
// \endrules
//
repeated BoundaryPoint boundary_line = 2;

// The classification of the lane boundary.
Expand Down
4 changes: 0 additions & 4 deletions osi_logicallane.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,10 +407,6 @@ message LogicalLane
// For LogicalLanes without a correspondence to a Lane.Classification.Subtype
// (i.e. TYPE_MEDIAN, TYPE_CURB, TYPE_TRAM, TYPE_RAIL) this field has no value.
//
// \rules
// refers_to: Lane
// \endrules
//
repeated PhysicalLaneReference physical_lane_reference = 4;

// The \link ReferenceLine reference line\endlink for this logical lane
Expand Down
2 changes: 1 addition & 1 deletion osi_sensorview.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ message SensorView
// The ID of the host vehicle in the \c #global_ground_truth data.
//
// \rules
// refers_to: 'MovingObject'
// refers_to: MovingObject
// is_set
// \endrules
//
Expand Down