Makefile Rework

Dockerfile

@@ -1,6 +1,6 @@
 ARG CONTEXT=prod
 
-FROM caddy:2.3.0-alpine as base
+FROM caddy:2.3.0-alpine AS base
 
 ## Setup
 ARG CONTEXT
@@ -30,17 +30,17 @@ CMD ["./command.sh"]
 
 # Development Image
 
-FROM base as dev
+FROM base AS dev
 
 ENV ENABLE_LOCAL_HTTPS=1
 
 # Testing Image
 
-FROM base as tests
+FROM base AS tests
 
 # Production Image
 
-FROM base as prod
+FROM base AS prod
 
 # Add appuser
 RUN adduser --system --no-create-home appuser && \

Makefile

@@ -1,14 +1,21 @@
-SERVICE=proxy
+override SERVICE=proxy
+
+# Build images for different contexts
 
 build-prod:
-	docker build ./ --tag "openslides-$(SERVICE)" --build-arg CONTEXT="prod" --target "prod"
+	docker build ./ $(ARGS) --tag "openslides-$(SERVICE)" --build-arg CONTEXT="prod" --target "prod"
 
 build-dev:
 	./make-localhost-cert.sh
-	docker build ./ --tag "openslides-$(SERVICE)-dev" --build-arg CONTEXT="dev" --target "dev"
+	docker build ./ $(ARGS) --tag "openslides-$(SERVICE)-dev" --build-arg CONTEXT="dev" --target "dev"
+
+build-tests:
+	docker build ./ $(ARGS) --tag "openslides-$(SERVICE)-tests" --build-arg CONTEXT="tests" --target "tests"
 
-build-test:
-	docker build ./ --tag "openslides-$(SERVICE)-tests" --build-arg CONTEXT="tests" --target "tests"
+# Tests
 
 run-tests:
-	echo "Proxy has no tests"
+	bash dev/run-tests.sh
+
+lint:
+	bash dev/run-lint.sh -l

dev/command.sh

@@ -1,4 +1,4 @@
 #!/bin/sh
 
 # Same command for all contexts
-caddy run --config /etc/caddy/config.json
+caddy run --config /etc/caddy/config.json

dev/run-lint.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+echo "########################################################################"
+echo "####################### Proxy has no linters ###########################"
+echo "########################################################################"

dev/run-tests.sh

@@ -1,5 +1,13 @@
 #!/bin/bash
 
+set -e
+
 echo "########################################################################"
 echo "###################### Proxy has no tests ##############################"
 echo "########################################################################"
+
+# Setup
+LOCAL_PWD=$(dirname "$0")
+
+# Linters
+bash "$LOCAL_PWD"/run-lint.sh