This repository was archived by the owner on Jul 22, 2025. It is now read-only.
revert low-res scale in GenerateRwpkInfo#72
Closed
inteltiger wants to merge 1 commit intoOpenVisualCloud:masterfrom
Closed
revert low-res scale in GenerateRwpkInfo#72inteltiger wants to merge 1 commit intoOpenVisualCloud:masterfrom
inteltiger wants to merge 1 commit intoOpenVisualCloud:masterfrom
Conversation
partial revert bbad95b
Contributor
Author
|
oh, i understand now. #62 has been merged it was an intented API change : it scaled UP the low resolution tile coordinates ( projRegWidth projRegHeight projRegLeft projRegTop ) to be aligned and mapped to the high resolution world but this change is NOT compatible with v1.4.0 , it can be considered as a bugfix i will change client side accordingly. and abandon this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial revert bbad95b