-
-
Notifications
You must be signed in to change notification settings - Fork 315
fix: ensure live2d blink focus in state is full #845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @HardyNLee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求旨在解决 Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
你好,感谢你对这个问题的修复。通过合并基础参数和传入的部分参数,你确保了 live2dBlink 和 live2dFocus 在 state 中始终是完整的,这有效地解决了所描述的 bug。
代码的逻辑是正确的。我只发现了一个可以改进的地方,即 setLive2dBlink 和 setLive2dFocus 两个 reducer 中存在重复的逻辑。我已经在代码中提出了一个具体的建议,旨在通过重构来提高代码的可维护性。
总体来说,这是一个很好的修复!
| if (index < 0) { | ||
| // Add a new blink | ||
| state.live2dBlink.push({ target, blink }); | ||
| const fullBlink = { ...baseBlinkParam, ...blink }; | ||
| state.live2dBlink.push({ target, blink: fullBlink }); | ||
| } else { | ||
| // Update the existing blink | ||
| state.live2dBlink[index].blink = blink; | ||
| const fullBlink = { ...state.live2dBlink[index].blink, ...blink }; | ||
| state.live2dBlink[index].blink = fullBlink; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
介绍
修复 stage state 中 live2dBlink 和 live2dFocus 参数可能不完整的问题
测试
changeFigure: path/to/model.json -id=aaa -focus={"x":-1} -next; :focus left; changeFigure: path/to/model.json -id=aaa -focus={"y":1} -next; :focus left up (继承上一句的 left);此 PR 前, 播放到最后一句, 再读档读到第一句, 并不会真的 focus left, 因为那时 focus 参数在 state 中不完整