Add Japanese Translation and Japanese Font Support#15
Open
hirowassan wants to merge 7 commits intoOrnitheMC:mainfrom
Open
Add Japanese Translation and Japanese Font Support#15hirowassan wants to merge 7 commits intoOrnitheMC:mainfrom
hirowassan wants to merge 7 commits intoOrnitheMC:mainfrom
Conversation
Added Japanese translation
Member
|
Thank you for your work, however do you think it is reasonable to not ship the font file with this program but instead rely on system fonts? See the related comment on #14 as it applies to Japanese as well. |
moehreag
reviewed
Feb 18, 2026
Cargo.toml
Outdated
| opt-level = 's' | ||
|
|
||
| [target.'cfg(target_os = "linux")'.dependencies] | ||
| fontconfig = "0.10.0" No newline at end of file |
Member
There was a problem hiding this comment.
This dependency should ideally also be restricted to the gui feature as the CLI does not need it
Member
|
Don't worry about the failing action too much, it should fix itself with a |
CrazyHPi
added a commit
to CrazyHPi/ornithe-installer-rs
that referenced
this pull request
Feb 20, 2026
CrazyHPi
added a commit
to CrazyHPi/ornithe-installer-rs
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Font File from Google Fonts
Tested in windows x64