Open
Conversation
moehreag
reviewed
Feb 20, 2026
moehreag
reviewed
Feb 20, 2026
Author
|
oops forgot about #14 commit, I'll force push it once. |
CrazyHPi
force-pushed
the
font-loader
branch
from
c35083c to
52bde3e
Compare
moehreag
reviewed
Feb 20, 2026
Member
|
I like the approach, but there are a few questions and potential improvements. |
Member
|
There are still a few warnings in the build logs, could you deal with them? After that I think this is ready to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will try to load fonts specified in
res/font/fonts.jsonfrom the operating system.For Mac and Windows, it will try to load from the system path.
For Linux, it uses
fontconfigto find the font path and load it from there.To add additional fonts, simply add the font name to
fonts.json