Skip to content

Conversation

@SpaceWalkerRS
Copy link
Member

The old pattern was something like this

PARSER = new PomParser("https://repository.com/com/example/artifact/maven-metadata.xml");
List<MavenBuildVersion> versions = PARSER.getMeta(MavenBuildVersion::new, "com.example:artifact:");

This is a weird pattern since the URL to the maven-metadata.xml already contains details about the maven group id and artifact id, but you still have to provide the maven notation "prefix" when calling getMeta.

Also, it's not even a POM parser.

The new pattern removes redundancy and makes the different elements of the maven notation more explicit:

PARSER = new MavenMetadataParser("https://repository.com/", "com.example", "artifact");
List<MavenBuildVersion> versions = PARSER.getVersions(MavenBuildVersion::new);

@SpaceWalkerRS SpaceWalkerRS requested a review from Copetan October 14, 2025 14:17
This was referenced Oct 14, 2025
@SpaceWalkerRS SpaceWalkerRS merged commit ec6e34b into main Oct 29, 2025
8 checks passed
@SpaceWalkerRS SpaceWalkerRS deleted the parser-refactor branch October 29, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants