-
Notifications
You must be signed in to change notification settings - Fork 0
move library upgrades to their own endpoints #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
46d4ad7 to
da12541
Compare
|
This PR does break the current installers so they will need to be updated. |
|
Is the intent for the library upgrades to be optional on installation? |
|
I didn't think of that. I reckon they should always be applied though, both in prod and dev. Otherwise you'll have strange crashes when mods depend on them but they're missing. |
|
I wonder if the library upgrades should be specified in a local file so updating them doesn't require updating the meta itself. |
|
I was wondering because the library upgrades were previously automatically applied to the profile json/zip endpoint, but now it seems that the library upgrades endpoint has to be called for the upgraded libraries to be applied upon installation |
|
I see what you mean. I did that to make it more explicit that the profile json is just that what is necessary for Loader. MMC/Prism instances keep the Loader dependencies and MC dependencies separate, so the installer has to do some jank to parse just the library upgrades from the profile JSON. |
|
TODO: rebase onto new logging system once that is merged |
dc7f04f to
0fa0d61
Compare
|
tested locally that it gives the correct results |
the new endpoints are
libraries/:game_version/and:generation/libraries/:game_version- this allows us to lock the upgrades for gen1 in place if we wish to do so